Closed timothystewart6 closed 9 months ago
If you go the way of using self-hosted runners for GitHub actions that are triggered for pull-request, make sure this option is enabled and set to Require approval for all outside collaborators
.
Also, ensure to only allow runs for pull requests that do not change workflow yaml configuration. This could lead to potentially unwanted code execution on the self-hosted runners and someone having access to a machine running in your environment.
If you go the way of using self-hosted runners for GitHub actions that are triggered for pull-request, make sure this option is enabled and set to
Require approval for all outside collaborators
. Also, ensure to only allow runs for pull requests that do not change workflow yaml configuration. This could lead to potentially unwanted code execution on the self-hosted runners and someone having access to a machine running in your environment.
Thank you! For sure! This is already enabled even prior to testing self-hosted runners! I will also make sure to ignore yaml changes for workflows, good call!
this was fixed by https://github.com/techno-tim/k3s-ansible/pull/389
CI takes a while to run, which is to be expected since we are spinning up VirtualBox VMs on a macOS via GitHub. I've tried running this in kubernetes #136 however Kubernetes isn't the right tool for the job considering that it uses containers and this CI pipeline needs to create and run VMs.
2 options if performance continues to be an issue:
Self Host VMs
Use K8s but provision Proxmox as a VM provider for Vagrant