techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.
https://technotim.live/posts/k3s-etcd-ansible/
Apache License 2.0
2.41k stars 1.05k forks source link

Split Manifest into individual job #186

Closed irish1986 closed 1 year ago

irish1986 commented 1 year ago

Proposed Changes

I have noticed working with this repo that I often end up adding more manifest and "goodies" features into it. Splitting manifest into individual files simplify adding new feature or debugging specific workload/

Furthermore, I proposed to add system-upgrade workload as part of the default configuration. System-upgrade allows to automated K3S image update via various means. Also it is a good use case on why splitting manifest could be useful

Checklist

timothystewart6 commented 1 year ago

Thanks! Looks like some lint! Also, wonder if you we can break this up into 2 PRs, one for reorg and one for system upgrade, that way each PR is limited to 1 change / feature and easy to roll back if needed. Thank you!

irish1986 commented 1 year ago

can break this up into 2 PRs

I taught about that, will do later today or maybe next week after holidays rush.

And I'll check what happens with the linter, I suspect I might have linted the wrong branch locally before pushing upstream.

irish1986 commented 1 year ago

I got mixed up in couple of changes and branches so I've decided the best is to close this PR and re-open it via a new PR. Sorry for the inconvenience just that I never had to split an existing PR.