techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.

https://technotim.live/posts/k3s-etcd-ansible/

Apache License 2.0

2.41k stars 1.05k forks source link

fix: Ensure role label on nodes #312

Closed sagiru closed 1 year ago

sagiru commented 1 year ago

it is generally more pleasant to set these roles.

Proposed Changes

Ensure the node role is configured as expected instead of beeing none.

(.venv) sascha@apu:~/git/dmix/ansible-infra$ k get nodes
NAME        STATUS   ROLES                       AGE   VERSION
...
intkwkr01   Ready    worker                      19d   v1.24.12+k3s1
intkwkr02   Ready    none                     19d   v1.24.12+k3s1

Checklist

[x] Tested locally
[x] Ran site.yml playbook
[x] Ran reset.yml playbook
[x] Did not add any unnecessary changes
[x] Ran pre-commit install at least once before committing
[ ] 🚀

sagiru commented 1 year ago

sascha@apu:~/.../k3s-ansible$ ansible-lint roles/k3s/post/tasks/main.yml 
WARNING: PATH altered to expand ~ in it. Read https://stackoverflow.com/a/44704799/99834 and correct your system configuration.

Passed with production profile: 0 failure(s), 0 warning(s) on 2 files.

timothystewart6 commented 1 year ago

Looks like there are merge conflicts now, would love to merge this in at some point!

timothystewart6 commented 1 year ago

We should probably go this route instead https://github.com/techno-tim/k3s-ansible/issues/339 Also, closing due to conflicts.