techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.
https://technotim.live/posts/k3s-etcd-ansible/
Apache License 2.0
2.41k stars 1.05k forks source link

Replace hardcoded 'master' group name with 'group_name_master' variable #337

Closed berendt closed 1 year ago

berendt commented 1 year ago

Proposed Changes

For improved flexibility and maintainability.

Checklist

timothystewart6 commented 1 year ago

Thank you! While I do like this idea, I feel like this should be backwards compatible. Any way to make this default to master if this variable is not provided?

timothystewart6 commented 1 year ago

@berendt looks like yaml lint

berendt commented 1 year ago

Looks like pre-commit uses a different yamllint configuration then .yamllint? The line-length should be a warning only.

---
extends: default

rules:
  line-length:
    max: 120
    level: warning
  truthy:
    allowed-values: ['true', 'false', 'yes', 'no']
timothystewart6 commented 1 year ago

Good call, I will look into it. Might need to load the config...

timothystewart6 commented 1 year ago

Thank you!