techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.

https://technotim.live/posts/k3s-etcd-ansible/

Apache License 2.0

2.41k stars 1.05k forks source link

sysctl tags #373

Closed johnnyrun closed 1 year ago

johnnyrun commented 1 year ago

Proposed Changes

pleae let me skip sysctl (advanced use)

Checklist

[ x] Tested locally
[x ] Ran site.yml playbook
[ ] Ran reset.yml playbook
[ ] Did not add any unnecessary changes
[ ] Ran pre-commit install at least once before committing
[ ] 🚀

timothystewart6 commented 1 year ago

Hi! Not sure what this change actually does and typically this should be configurable vs. hardcoded

johnnyrun commented 1 year ago

Hi Tim.

Basically it does only tag the task and not changing the behaviour. I would like this because I manage sysctl parameters on another role and my role and yours are conflicting on ipv6 sysctl setup (not mandatory for k3s).

Tagging the task permit me to use the "skip-tags" in parameter calling ansible-playbook and avoid forking this repo

timothystewart6 commented 1 year ago

Thanks for the clarification! I think we should also add this too for consistency

https://github.com/techno-tim/k3s-ansible/blob/de32bf6c7164a49b0413854bf4cc9ecdb6bc3cfd/roles/prereq/tasks/main.yml#L49

timothystewart6 commented 1 year ago

After we add that additional tag to the prereqs, it's good to go!

giannicarabelli commented 1 year ago

ops.. my fault. Pushed

timothystewart6 commented 1 year ago

Thank you!