techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.
https://technotim.live/posts/k3s-etcd-ansible/
Apache License 2.0
2.41k stars 1.05k forks source link

initial galaxy.yml #388

Closed egandro closed 9 months ago

egandro commented 1 year ago

Proposed Changes

Add a galaxy.yml file to use as collection in bigger ansible projects.

Instructions:

collections:
  - name: ansible.utils
  - name: community.general
  - name: ansible.posix
  - name: kubernetes.core
  - name: https://github.com/techno-tim/k3s-ansible.git
    type: git
    version: master

Checklist

timothystewart6 commented 1 year ago

this closes https://github.com/techno-tim/k3s-ansible/issues/198

timothystewart6 commented 1 year ago

lint, after that's fixed I will make some modifications to this file

bdsoha commented 1 year ago

@egandro Great PR. IMO, might be nice to also add instructions to the README.md.

egandro commented 1 year ago

lint, after that's fixed I will make some modifications to this file

I have no clue how / what you want to lint me. The file was created with the ansible-galaxy command. There is really nothing we can make better, as all of the ansible galaxy files have this layout.

Please clearify what I should do.

egandro commented 1 year ago

@egandro Great PR. IMO, might be nice to also add instructions to the README.md.

Done. Please check if that is ok.

timothystewart6 commented 1 year ago

lint, after that's fixed I will make some modifications to this file

I have no clue how / what you want to lint me. The file was created with the ansible-galaxy command. There is really nothing we can make better, as all of the ansible galaxy files have this layout.

Please clearify what I should do.

The build is failing because linting is failing. You can see it here

https://github.com/techno-tim/k3s-ansible/actions/runs/6707725821/job/18248637705

You can also check and fix these locally by using pre-commit https://github.com/techno-tim/k3s-ansible#pre-commit-hooks

egandro commented 1 year ago

The build is failing because linting is failing. You can see it here

I fixed it - by ignoring it :)

egandro commented 12 months ago

I have no idea what is breaking.

timothystewart6 commented 12 months ago

I have no idea what is breaking.

Check the build logs, it's in there. Lint. The first step.

https://github.com/techno-tim/k3s-ansible/actions/runs/6722041556/job/18304808757?pr=388#step:7:149

timothystewart6 commented 12 months ago

@egandro

see this comment, it's the same thing. Just install pre-commit and you won't have these issues

https://github.com/techno-tim/k3s-ansible/pull/388#issuecomment-1788295372

egandro commented 12 months ago

@egandro

see this comment, it's the same thing. Just install pre-commit and you won't have these issues

#388 (comment)

Edit:

Legit ... "ansible-galaxy collection init techno_tim.k3s_ansible"

It creates 2 empty lines at the end of the galaxy.yml file ... it's "them" not "us".

timothystewart6 commented 12 months ago

@egandro see this comment, it's the same thing. Just install pre-commit and you won't have these issues #388 (comment)

Edit:

Legit ... "ansible-galaxy collection init techno_tim.k3s_ansible"

It creates 2 empty lines at the end of the galaxy.yml file ... it's "them" not "us".

Well I have strict lint code style on this repo. It's pretty common with all code bases. Just because something else generated it does not mean it matches the target's code style.

again, just install pre-commit like the docs show and it will fix it

egandro commented 12 months ago

Well I have strict lint code style on this repo. It's pretty common with all code bases. Just because something else generated does not mean it matches the target's code style.

I totally understand the reasons and the why you are doing this. 100% legit and I agree.

I haven't got beaten up by ansible galaxy when trying to actually deploy it to their repos.

There might be good resons - not - to mess a lot with galaxy.yml (which is a fair guestimation) with my knowledge at this point.

timothystewart6 commented 12 months ago

Well I have strict lint code style on this repo. It's pretty common with all code bases. Just because something else generated does not mean it matches the target's code style.

I totally understand the reasons and the why you are doing this. 100% legit and I agree.

I haven't got beaten up by ansible galaxy when trying to actually deploy it to their repos.

There might be good resons - not - to mess a lot with galaxy.yml (which is a fair guestimation) with my knowledge at this point.

yaml is yaml, fixing lint does not change the schema 😄

timothystewart6 commented 12 months ago

Thanks for sticking with it @egandro ! We're having some issues with the CI job running the rest of the tests. As soon as it's resolved I will merge this!

fresh2dev commented 9 months ago

Thanks for this! Very helpful addition :+1: