techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.
https://technotim.live/posts/k3s-etcd-ansible/
Apache License 2.0
2.41k stars 1.05k forks source link

Bump kube-vip to v0.7.1 #464

Closed yebo29 closed 8 months ago

yebo29 commented 8 months ago

Expected Behavior

We're running an outdated version of kube-vip. Are there any reasons not to update to latest v0.7.1? I did so on my local system and nothing seems to have broken, but I haven't fully put it through its paces. There is one change on how it's deployed, however. The path to the RBAC manifest now lives at a different URL and not tied to a release tag. Will this cause issues in the future? I don't know enough about RBAC to know. I was thinking of opening a PR with my changes but wanted to post an issue first.

I attempted the upgrade to see if it would fix an unrelated issue. While it did not fix the issue I was having, I do not fault kube-vip for it. I think the problem lies more with Litestream and how SQLite works.

I don't have a good reason to update kube-vip beyond just keeping things current. Nothing in the changelogs jumped out at me.

v0.6.4 -> 0.7.0 -> 0.7.1

Current Behavior

Kube-vip on v0.6.4

Steps to Reproduce

Not a bug; no steps to reproduce.

Context (variables)

Operating system: I've only tested on my local 3 node cluster running on Raspbian

Hardware: Pi4 Model B

Variables Used

all.yml

k3s_version: "v1.29.0+k3s1"
ansible_user: NA
systemd_dir: "/etc/systemd/system"

flannel_iface: "eth0"

#calico_iface: ""
calico_ebpf: ""
calico_cidr: ""
calico_tag: ""

apiserver_endpoint: ""

k3s_token: "NA"

extra_server_args: ""
extra_agent_args: ""

kube_vip_tag_version: "v0.7.1"

kube_vip_cloud_provider_tag_version: ""
kube_vip_lb_ip_range: ""

metal_lb_speaker_tag_version: "v0.13.12"
metal_lb_controller_tag_version: "v0.13.12"

metal_lb_ip_range: ""

Hosts

host.ini

[master]
IP.ADDRESS.ONE

[node]
IP.ADDRESS.TWO
IP.ADDRESS.THREE

[k3s_cluster:children]
master
node

Possible Solution

timothystewart6 commented 8 months ago

Thanks! I love keeping things up to date. PR is welcome! Might be worth checking metallb too! Thanks!

yebo29 commented 8 months ago

Thanks for your input. I'll put one in when I get a chance. Might be later in the week depending on day job work load.

timothystewart6 commented 8 months ago

closed by https://github.com/techno-tim/k3s-ansible/pull/469