techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.

https://technotim.live/posts/k3s-etcd-ansible/

Apache License 2.0

2.41k stars 1.05k forks source link

feat: move playbooks to playbooks directory to fully qualified name references (#557) #563

Open ednxzu opened 2 months ago

ednxzu commented 2 months ago

Proposed Changes

This PR moves the playbooks from the root of the repository to a dedicated playbooks/ directory to follow ansible guidelines on building collections.
This also allows playbooks to be referenced by their fully qualified names (eg. techno_tim.k3s_ansible.site.yml) from outside the repository once the collection is installed, allowing easier integration into bigger codebases.

Checklist

[X] Tested locally
[X] Ran site.yml playbook
[X] Ran reset.yml playbook
[X] Did not add any unnecessary changes
[X] Ran pre-commit install at least once before committing
[x] 🚀

timothystewart6 commented 2 months ago

The challenge is that this essentially changes how people use this in its current state. I am not sure I am ready to break the current implementation of how this works (from an end user's perspective)

https://technotim.live/posts/k3s-etcd-ansible/

ednxzu commented 2 months ago

I can revert the removal of the root path playbooks, so that the old way keeps working. The only change on user's end would be the path of the playbook. People don't have to use the fully qualified name to run the playbook, they can ansible-playbook -i inventory playbooks/site.yml, This simply enables the option to use fully qualified names.