search

techno-tim / k3s-ansible

The easiest way to bootstrap a self-hosted High Availability Kubernetes cluster. A fully automated HA k3s etcd install with kube-vip, MetalLB, and more. Build. Destroy. Repeat.
https://technotim.live/posts/k3s-etcd-ansible/
Apache License 2.0
2.41k stars 1.05k forks source link

CI: Fix linting job for ansible-lint 6.6.0 #96

Closed sleiner closed 2 years ago

sleiner commented 2 years ago

Proposed Changes

Checklist

ioagel commented 2 years ago

I really cannot understand why you did not consider my pull request where I fix all the linting problems and the master taint implementation! You came and broke my pull request, without any consideration, when you could make your changes on the lint.yml file on top of my changes.

sleiner commented 2 years ago

@ioagel first of all: sorry for that! The explanation is quite simple: I did not see your PR in time, I have just looked at it a few minutes ago 😬 Still, I think there is value to fixing the linter job without requiring the more sophisticated changes from #95 first.

But if you want to, I will gladly resolve the conflicts in your PR for you 😊

sleiner commented 2 years ago

Seems there is a new flakiness in town :/ If this happens again, we might have to add a retry mechanism here... https://github.com/techno-tim/k3s-ansible/actions/runs/3092105672/jobs/5004611238#step:7:367

ioagel commented 2 years ago

@ioagel first of all: sorry for that! The explanation is quite simple: I did not see your PR in time, I have just looked at it a few minutes ago 😬 Still, I think there is value to fixing the linter job without requiring the more sophisticated changes from #95 first.

But if you want to, I will gladly resolve the conflicts in your PR for you 😊

you are right… about the linter… I hacked my way to fixing stuff! Your changes are more clean…

timothystewart6 commented 2 years ago

Thank you!