search

techno-tim / littlelink-server

A lightweight, open source, stateless, and self-hosted alternative to linktree in a Docker container!
https://links.technotim.live
MIT License
901 stars 164 forks source link

EMail ALT Text #6

Closed WhyAydan closed 3 years ago

WhyAydan commented 3 years ago

Hey, Looks like the email ALT text has been statically set to 'hello@littlelink.io'

Fixed it by manually setting it in the index.html but for future if you do any updates :)

Aydan

madvip3r commented 3 years ago

If possible, it would be nice, to add in line 156 and 160 a configurable placeholder as is done for links.

Anthonyyp commented 3 years ago

@WhyAydan came to post about this exactly - am new at docker - how do you access the index.html file within a docker container like this?

madvip3r commented 3 years ago

@Anthonyyp the problem with editing index.html inside docker container is that this change will only last as long docker container lives. At the next restart of the container (that is, next change) it will be reverted back to original state.

WhyAydan commented 3 years ago

@Anthonyyp Hey so you need to terminal in the Docker Container then cd into www. Once in there you need to type vi index.html Use the arrow keys to find the email place holder once you found it press the i key. Edit the field and then press CTRL+C followed by :wq

Let me know if you need more help

Anthonyyp commented 3 years ago

@Anthonyyp the problem with editing index.html inside docker container is that this change will only last as long docker container lives. At the next restart of the container (that is, next change) it will be reverted back to original state.

That's what I thought - am new to docker and containerization.

@Anthonyyp Hey so you need to terminal in the Docker Container then cd into www. Once in there you need to type vi index.html Use the arrow keys to find the email place holder once you found it press the i key. Edit the field and then press CTRL+C followed by :wq

Let me know if you need more help

I'm SSH'd into the machine running it and have been combing through directories and I can not find where the www folder is. I must be overlooking something.

madvip3r commented 3 years ago

@Anthonyyp you can use docker command to "ssh" into the container: docker exec -it CONTAINER_ID bash

Replace CONTAINER_ID with name or id of container. When you want to get back, you just enter exit or Ctrl-D.

timothystewart6 commented 3 years ago

This has been fixed by https://github.com/techno-tim/littlelink-server/commit/77c5cfba2a57ea55e7220e19c81a5ed8de2b14ef

It should now render your email within the button! Sorry about that and thanks for reporting it!