search

technocreatives / sim7000

Rust drivers for the SIM7000 series of modems
Apache License 2.0
18 stars 8 forks source link

Fix issue with AT+CPSI in GSM mode #8

Closed ZoeyR closed 2 years ago

ZoeyR commented 2 years ago

The sim7000 has a bug where in GSM mode the AT+CPSI command will respond with two newlines after the informational line instead of just one. Change the parser to be able to handle this and add tests to prevent regression.

codecov[bot] commented 2 years ago

Codecov Report

Merging #8 (56c4b9e) into main (18c37df) will increase coverage by 5.30%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   29.72%   35.02%   +5.30%     
==========================================
  Files          32       32              
  Lines         730      748      +18     
==========================================
+ Hits          217      262      +45     
+ Misses        513      486      -27
Impacted Files Coverage Δ
src/commands/cpsi.rs 80.48% <95.23%> (+80.48%) :arrow_up:
src/commands/mod.rs 60.00% <0.00%> (+11.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18c37df...56c4b9e. Read the comment docs.