search

technojam / AndroidCustomView

This repository consist of some custom views and UI components for android
4 stars 31 forks source link

Fixes:#4 CustomView added - ColorVIew #3

Closed abhi114 closed 3 years ago

abhi114 commented 3 years ago

Fixes #4 implemented the rect with default green color. implemented the swap button upon pressing the swap color button the color of the rect changes

WhatsApp Image 2020-09-27 at 5 42 25 PM

noman2002 commented 3 years ago

Hi @abhi114, good work! A few points - Please change your PR title to this format: Fix#IssueNumber:Description Also, as mentioned earlier, please mention the following in your PR description:

  • Fixes#IssueNumber
  • Description of the change

@Sarthak2601 actually there is no issues at this repo he is just adding new views to the app. So, there not be any #issueNumber.

Sarthak2601 commented 3 years ago

Hi @abhi114, good work! A few points - Please change your PR title to this format: Fix#IssueNumber:Description Also, as mentioned earlier, please mention the following in your PR description:

  • Fixes#IssueNumber
  • Description of the change

@Sarthak2601 actually there is no issues at this repo he is just adding new views to the app. So, there not be any #issueNumber.

@noman2002 Yes this is why I suggested to open an issue first and then open a PR corresponding that issue. Also, FYI #4 is the issue number for this PR.

noman2002 commented 3 years ago

Hi @abhi114, good work! A few points - Please change your PR title to this format: Fix#IssueNumber:Description Also, as mentioned earlier, please mention the following in your PR description:

  • Fixes#IssueNumber
  • Description of the change

@Sarthak2601 actually there is no issues at this repo he is just adding new views to the app. So, there not be any #issueNumber.

@noman2002 Yes this is why I suggested to open an issue first and then open a PR corresponding that issue. Also, FYI #4 is the issue number for this PR.

@Sarthak2601 Got it