search

technojam / technojam-frontend

This is the repository for TechnoJam's website frontend, for work please work on Development 1.0. Please do git pull before giving a pull request.
https://technojam--web.herokuapp.com/
MIT License
33 stars 97 forks source link

:bug: Fixed name color not changing on dark mode and changed social icons color #277

Closed abdulsamad closed 3 years ago

abdulsamad commented 4 years ago

TechnoJam (1) TechnoJam

Switched to the functional component, added prop types, and fixed the bug. It may have issues (probably :sweat_smile: ) as this is my first contribution.

Ritwik880 commented 4 years ago

@abdulsamad I don't think the issue has resolved yet. Please have a look into it.

Screenshot from 2020-10-15 19-53-12

abdulsamad commented 4 years ago

Peek 2020-10-15 20-09

@Ritwik880 It's working on my machine locally and I can see the code in the pull request.

bug

abdulsamad commented 4 years ago

Maybe I've messed up in sending a pull request. Can you please check?

mohdorusaid commented 4 years ago

Hey @abdulsamad , we don't want to change the class-based component to a functional one, and one more PR has done this work without resorting to these changes. However, we value your efforts and we won't close this PR. The hacktoberfest label has already been added, so this PR will be counted in your contributions. Happy hacking!

abdulsamad commented 4 years ago

@mohdorusaid No problem