search

technologiestiftung / giessdenkiez-de-dwd-harvester

Gather precipitation data from DWD's radolan data set, for the region of Berlin and connect to the trees DB
https://www.giessdenkiez.de
MIT License
4 stars 9 forks source link

Use Github container registry? #91

Open sjockers opened 1 year ago

sjockers commented 1 year ago

I was wondering if it would be possible (and/or make sense) to use the Github container registry to release the docker image, rather than Docker Hub?

That would reduce the number of online services needed to run localized versions of GDK, and it may enable you to get rid of the docker-pull workaround.

Also, if I understand correctly, the release actions currently expect a Docker user of the same name as the Github org, which works for technologiestiftung but may not work for other organizations.

sjockers commented 1 year ago

Paging @ff6347 and @JensWinter because you may have an opinion on this one.

ff6347 commented 1 year ago

As far as I can see the action is not bound to the technologiestiftung handle. Can you give me an example?

Yes the docker pull workaround is not nice. Would be nice to get rid of it.

sjockers commented 1 year ago

As far as I can see the action is not bound to the technologiestiftung handle. Can you give me an example?

What I mean is that it's bound to the handle of the user/organization publishing it. In our case that's digifarms-ms, therefore the image repository would be docker.io/digifarm-ms/giessdenkiez-de-dwd-harvester. That generally makes sense, but in this case it won't work. As far as I can tell, I can't create the namespace digifarms-ms on Docker because I can't create a user of the same name (Docker does not allow dashes in user names).

Example: https://github.com/digifarm-ms/giessdenkiez-de-dwd-harvester/actions/runs/4908472415/jobs/8766614537#step:3:1787

It's a stupid problem, I'll see what I can do about it.

ff6347 commented 1 year ago

Ah okay. But the workflow itself does not need to be published as image. This is only implemented to keep it portable. When using the workflow, as I understand github docker actions, the image is build in the moment when the workflow runs. So there is no need to publish it as image to use it.

sjockers commented 1 year ago

Ah, I see. That wasn't clear to me. Thanks for explaining!

ff6347 commented 1 year ago

Generally I still think it would be good to publish to ghcr.io Since my overall feeling is we can't trust that docker.com will change their terms of service at any point and might charge us for storing images. So I keep this open.