search

technologiestiftung / jahresbericht-2021

MIT License
1 stars 2 forks source link

ci(netlify): Configure netlify deploys #28

Closed ff6347 closed 2 years ago

ff6347 commented 2 years ago

This PR adds a netlify.toml file for configuring the deploys on Netlify. @ZenVega Please check if this is right.

netlify[bot] commented 2 years ago

Deploy Preview for jahresbericht-2021 ready!

Name Link
Latest commit 2ccc99312cad4e2b9e1d37798e3c50b89a8d62da
Latest deploy log https://app.netlify.com/sites/jahresbericht-2021/deploys/6285e67e81154e000889871d
Deploy Preview https://deploy-preview-28--jahresbericht-2021.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ZenVega commented 2 years ago

ich glaube es gibt einen build error, weil die fonts im gitignore liegen und händisch eingefügt werden müssen: image

ff6347 commented 2 years ago

ich glaube es gibt einen build error, weil die fonts im gitignore liegen und händisch eingefügt werden müssen: image

This is suboptimal. If you want to use CI/CD you need to include those files in the repo or you need to have a build step that pulls these files in before you do the build on the CI server. Please take a look into the other repos of the org to see how this is handled elsewhere. I did a quick search and the Clan is used in the org but not the ClanWebPro.

ZenVega commented 2 years ago

I had this topic before with @vogelino . The idea was to make the font not public, since it's not a free font and therefore took it out to make it only available to our developers. Is there a better solution or should I just take it in again?

MRigal commented 2 years ago

@ZenVega ich glaube du kannst es fixen: https://app.netlify.com/sites/jahresbericht-2021/deploys/628508b5e463820008e56d5e#L116

@ff6347 würde der linter das nicht schon vorab abgreifen?

4:55:50 PM: Failed to compile.
4:55:50 PM: 
4:55:50 PM: src/components/ScrollableImages/index.js
4:55:50 PM:   Line 14:38:  'ui' is defined but never used  no-unused-vars
ff6347 commented 2 years ago

@ff6347 würde der linter das nicht schon vorab abgreifen?

If eslint is configured right it should warn in VSCode

ZenVega commented 2 years ago

yes, it warned me. wasn't an error though. should work now

ff6347 commented 2 years ago

@all-contributors please add @ff6347 for infra

allcontributors[bot] commented 2 years ago

@ff6347

I've put up a pull request to add @ff6347! :tada: