technomancy / emacs-starter-kit

[ARCHIVED] this is ancient history
GNU General Public License v3.0
2.86k stars 886 forks source link

fixed deprecated ido-ubiquitous call #161

Closed apella-zz closed 11 years ago

apella-zz commented 11 years ago

the function ido-ubiquitous is deprecated, ido-ubiquitous-mode should be called, according to a compilation warning of the starter-kit.

(and I have a mode on that will remove trailing whitespace and I didn't notice that it had changed the file at lines 113 and 132 as well until later)

Kind regards, Bart S.

rslima commented 11 years ago

Will someone apply this patch? Starter kit is not working with the new version of ido-ubiquitous

DarwinAwardWinner commented 11 years ago

The fix should be (ido-ubiquitous-mode 1), to indicate that the mode should be unconditionally activated, not toggled.

Anyway, I've just added back in the obsolete alias for now, since I didn't realize the starter kit was still using it.

technomancy commented 11 years ago

I can merge this, but I don't have any plans to continue development; please see https://github.com/technomancy/emacs-starter-kit/blob/v3/README.markdown for details.

DarwinAwardWinner commented 11 years ago

Thanks for the merge.