Closed ghost closed 11 years ago
All functions that expect paths should not make any assumptions about characters in the path. Unfortunately, without inspecting each test ns, it is hard to tell more. I definitely think that Leiningen tests should pass on Windows, although admittedly, almost all contributions from Windows users are around fixes to the lein.bat
file
and none of the active contributors uses Windows.
there is a flaw in normalize-path
related to this [1] where it doesn't recognize paths like /tmp/lein-sample-project/src
as absolute so it ends up adding the root project to the path so it yields /tmp/lein-sample-project/tmp/lein-sample-project/src
but since this happens under windows only! it looks more like this s:\\tmp\\lein-sample-project\\tmp\\lein-sample-project\\src
Should I just check if it has a starting /
before attempting to do the (io/file root path)
and only do it if it doesn't ?
Code here btw [2]
[1] http://stackoverflow.com/questions/5154754/why-is-file-isabsolute-platform-dependent-when-the-file-class-is-platform-inde [2] https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/classpath.clj#L255-L257
bin\lein test
when run on Windows gives lots of errors mainly due to path separators differencehere's the full output (100 chars on horizontal) (EDIT: replaced with 100 chars on horizontal instead of previous 140) ran against: https://github.com/technomancy/leiningen/commit/92615f15ce7abf9d91e1af826a0ebdd49c1002e2
(FIXED this one)If you've read this far, at least one thing is wrong
"jri.dll rJava.dll"
search for that in the project. It's supposed to be 2 Strings.I could work on making these work on Windows too, if anyone would suggest exactly what to do :) (like: make a function which replaces path separators depending on the current OS?)