search

technomancy / leiningen

Moved to Codeberg; this is a convenience mirror
https://codeberg.org/leiningen/leiningen
Other
7.29k stars 1.61k forks source link

Ability to provide custom LEIN_JAR location #2775

Closed ahmedkirasystems closed 2 years ago

ahmedkirasystems commented 2 years ago

This is extremely useful when the JAR isn't available in the usual location. This is already implemented in other flavors. https://github.com/technomancy/leiningen/blob/f1921a55ae83c419ef4528f92c65a01f48603b80/bin/lein.bat#L31

This is particularly useful for when external build tools where JAR location path can't be the same as this script expects. This is will particularly help the case with Bazel's http_jar rule when running in sandbox mode. https://docs.bazel.build/versions/4.2.1/repo/http.html#http_jar

technomancy commented 2 years ago

Makes sense; can't see this doing any harm. Thanks.

technomancy commented 2 years ago

How would you like me to put your name in the changelog?

ahmedkirasystems commented 2 years ago

thanks for accepting the PR. Go for for it @technomancy, its Ahmed Sajid.