search

technomancy / leiningen

Moved to Codeberg; this is a convenience mirror
https://codeberg.org/leiningen/leiningen
Other
7.29k stars 1.61k forks source link

Add "repl :headless :socket PATH" support #2799

Closed rlbdv closed 1 year ago

rlbdv commented 2 years ago

Just for review, I've structured the commits so that the socket test can be run by installing current nrepl 1.0.0-SNAPSHOT, checking out the "Update nrepl to 1.0.0-SNAPSHOT for test-headless-socket" commit, and running lein test :only leiningen.test.repl/test-headless-socket. (Some of the existing tests don't appear to be compatible with the new nrepl.)

The subsequent commits just revert the nrepl version change, and mark that test as :disabled. Before merging, I suspect we may want to squash everything into the first commit, and I'd be happy to do so.

technomancy commented 1 year ago

Thanks; I've merged this in b676f29. We can re-enable the test once the new nrepl is released.

bbatsov commented 1 year ago

Might be good to also mention this somewhere in the docs.

technomancy commented 1 year ago

@bbatsov it's mentioned in the help text for the repl task and also in sample.project.clj; is there somewhere else that you had in mind?

bbatsov commented 1 year ago

Ah, I totally missed the sample.project.clj change. I guess we're good - I just wanted to make sure the end users will be able to find this.