technomancy / leiningen

Moved to Codeberg; this is a convenience mirror
https://codeberg.org/leiningen/leiningen
Other
7.29k stars 1.61k forks source link

Use name of namespaced keywords in repo maps to control env var lookup #756

Closed cemerick closed 12 years ago

cemerick commented 12 years ago

Currently, you can use :env to specify that a value in a repository map should be pulled from the environment. e.g. this:

"releases" {:url "http://blueant.com/archiva/internal"
            :username "milgrim" :password :env}

…will set the value of :password to the value of the $LEIN_PASSWORD env var.

Let's use a namespaced keyword there (perhaps requiring it?) in order to specify the env var name to use for each value. The example above would become:

"releases" {:url "http://blueant.com/archiva/internal"
            :username "milgrim" :password :env/lein-password}

This will allow different sets of credentials to be loaded from the environment even if they all use :password, e.g. :env/repo1-password, :env/repo3-username, etc.

bruceadams commented 12 years ago

@cemerick dealt with this issue in 268d72379697b73e2672eff191ab83030fc63c33

This issue can be closed.

technomancy commented 12 years ago

Oh gotcha; missed that somehow. Thanks.