Always assumes any capitalized symbol is a class...

[AlexBaranosky]

For better or for worse we have some vars that are capitalized, and clj-schema assumes they are classes.

[guns]

Hi @AlexBaranosky,

It appears to me that you fixed this issue in:

https://github.com/technomancy/slamhound/commit/e2f7d95d#L2R28

Since failure-details returns [:import :require-refer], for capitalized symbols, the search starts with matching imports then to matching vars, which I think is the correct order of precedence.

Therefore given:

;; foo.clj
(ns foo)
(def Foo nil)

;; bar.clj
(ns bar)
(def bar Foo)

Slamhound correctly regrows bar as:

(ns bar
  (:require [foo :refer [Foo]]))

So long as Foo is not the name of a class on the classpath.

Could you please confirm this is fixed, or am I misunderstanding something?

Thanks!

[guns]

Ah, nevermind. I see the issue is that if some.package.Foo and a var named Foo both exist, the class Foo is always chosen irrespective of any existing ns :import specs.

Hence the fix to #26 should fix this as well. I'll work on this next.

[guns]

Fixed by #53