technomancy / slamhound

Slamhound rips your namespace form apart and reconstructs it.
Other
473 stars 38 forks source link

Fix: make it work with nREPL 0.2.10. #88

Open bizenn opened 9 years ago

bizenn commented 9 years ago

Tested with: ; CIDER 0.10.0snapshot (package: 20150820.852) (Java 1.8.0_60, Clojure 1.7.0, nREPL 0.2.10)

nberger commented 9 years ago

@bizenn: this is almost a duplicate of #86. To join forces, I think it'd be better if you comment there about the small difference in both solutions.

bizenn commented 9 years ago

nrepl-client.el was refactered and nrepl-send-string-sync was renamed to nrepl-sync-request:eval at 0.8.0. See: https://github.com/clojure-emacs/cider/blob/master/CHANGELOG.md

86 looks not work on recent nREPL.

So, I use nrepl-sync-request:eval instead of nrepl-send-string-sync. That's the difference.

nberger commented 9 years ago

Thanks @bizenn. It looks like #84 & #86 should be closed. Let's see what @guns thinks.