search

technomancy / slamhound

Slamhound rips your namespace form apart and reconstructs it.
Other
473 stars 38 forks source link

Remove clojurescript :dev dependency that fails to resolve. #95

Closed technomancy closed 4 years ago

technomancy commented 7 years ago

The Clojurescript dependency in the :dev profile fails to resolve, and is not needed for the tests to pass. I don't know why it was added, so I won't remove it directly myself.

Retrieving org/apache/ant/ant-launcher/1.8.2/ant-launcher-1.8.2.jar from central
Retrieving com/googlecode/jarjar/jarjar/1.1/jarjar-1.1.jar from central
Retrieving org/apache/ant/ant/1.8.2/ant-1.8.2.jar from central
Retrieving com/google/guava/guava/13.0.1/guava-13.0.1.jar from central
Retrieving com/google/javascript/closure-compiler/r2180/closure-compiler-r2180.jar from central
Could not transfer artifact com.google.javascript:closure-compiler:jar:r2180 from/to central (https://repo1.maven.org/maven2/): GET request of: com/google/javascript/closure-compiler/r2180/closure-compiler-r2180.jar from central failed
Could not find artifact com.google.javascript:closure-compiler:jar:r2180 in clojars (https://clojars.org/repo/)
Could not transfer artifact com.google.guava:guava:jar:13.0.1 from/to central (https://repo1.maven.org/maven2/): GET request of: com/google/guava/guava/13.0.1/guava-13.0.1.jar from central failed
Could not find artifact com.google.guava:guava:jar:13.0.1 in clojars (https://clojars.org/repo/)
Could not find artifact com.google.guava:guava:jar:13.0.1 in caja (http://google-caja.googlecode.com/svn/maven)
Could not transfer artifact org.apache.ant:ant:jar:1.8.2 from/to central (https://repo1.maven.org/maven2/): GET request of: org/apache/ant/ant/1.8.2/ant-1.8.2.jar from central failed
Could not find artifact org.apache.ant:ant:jar:1.8.2 in clojars (https://clojars.org/repo/)
Could not find artifact org.apache.ant:ant:jar:1.8.2 in caja (http://google-caja.googlecode.com/svn/maven)
Could not transfer artifact org.apache.ant:ant-launcher:jar:1.8.2 from/to central (https://repo1.maven.org/maven2/): GET request of: org/apache/ant/ant-launcher/1.8.2/ant-launcher-1.8.2.jar from central failed
Could not find artifact org.apache.ant:ant-launcher:jar:1.8.2 in clojars (https://clojars.org/repo/)
Could not find artifact org.apache.ant:ant-launcher:jar:1.8.2 in caja (http://google-caja.googlecode.com/svn/maven)
Could not transfer artifact com.googlecode.jarjar:jarjar:jar:1.1 from/to central (https://repo1.maven.org/maven2/): GET request of: com/googlecode/jarjar/jarjar/1.1/jarjar-1.1.jar from central failed
Could not find artifact com.googlecode.jarjar:jarjar:jar:1.1 in clojars (https://clojars.org/repo/)
Could not find artifact com.googlecode.jarjar:jarjar:jar:1.1 in caja (http://google-caja.googlecode.com/svn/maven)
This could be due to a typo in :dependencies or network issues.
If you are behind a proxy, try setting the 'http_proxy' environment variable.
guns commented 7 years ago

Commit 3f7f8c7a8e4e9bfa35f207e63f79fe17bddb6911 sums up Slamhound's handling of CLJS:

Add namespaces beginning with "cljs." to the blacklist

Many contrib libraries ship with Clojure (clojure.foo) and ClojureScript (cljs.foo) namespaces. Because the CLJS namespaces contain many of the same vars as their Clojure counterparts, these namespaces frequently appear in candidate lists. Furthermore, they often win the disambiguation process since "cljs" is shorter than "clojure".

Slamhound does not currently support ClojureScript, so blacklisting these namespaces for the time being is quite convenient.

The CLJS dependency was added earlier in 6fa155e0937c6f1f296224f0a9b9469fe960cc1b, but the rationale is the same, IIRC.

Removing this dependency is just fine, but what might be better is bumping up the versions for both the org.clojure/clojure and org.clojure/clojurescript deps. Being a bit out of the Clojure loop atm, I think the decision is best left to you.

technomancy commented 4 years ago

Closing this out since it's old and stale.