technosaurus / PDMP3

Public domain mp3 decoder
130 stars 8 forks source link

output has audible artefacts #7

Open audioboy77 opened 7 years ago

audioboy77 commented 7 years ago

I got the library to work, by reverting to the older commit before the streaming functions were added.

i can decode an MP3 ok, unfortuantely there are noticable 'scratchy' type sounds present in the output. this is in comparison to audacity where the quality is much better.

it would be great if this could be fixed. otherwise. the library is not usable in a professional application, and i would hope others looking for a non-LGPL decoder do not waste a day setting it up as i did.

audioboy77 commented 7 years ago

Ok, it seems that the library works fine (the last commit from the original author, not the newer one) provided that the mp3 is not variable bit rate encoding.

any chance of a fix for this?

hajimehoshi commented 6 years ago

Does #9 help? I found fixing #9 eliminated at least one MP3 file's glitches.

BeamdogZach commented 6 years ago

I can confirm #9 fixed my issues with scratchiness using OpenMP3, though I wasn't using variable bit rate.

audioboy77 commented 6 years ago

Ok interesting. I will check that in OpenMP3 (I'm the developer) and see if it fixes the issue with the test file.

audioboy77 commented 6 years ago

I updated OpenMP3 with this fix, thanks. It fixes the issue in the test file which previously had artefacts.