search

technote-space / package-version-check-action

GitHub Actions to check package version before publish
MIT License
36 stars 1 forks source link

Package Version Check Not Working? #238

Open samdevaprasadvarde opened 2 years ago

samdevaprasadvarde commented 2 years ago

I created a .github/workflow/check_version.yml file with content of this as shown in the README:

on: push
name: Check package version
jobs:
  checkVersion:
    name: Check package version
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2

      # Use this GitHub Action
      - name: Check package version
        uses: technote-space/package-version-check-action@v1
        with:
          BRANCH_PREFIX: release/

I see that it runs on my repo when I create a PR, but it shows as passing even though I didn't update the version in the package.json file. How does this github action work and am I using it wrong? Tried a few different variations with the "with:", but all in vain.

welcome[bot] commented 2 years ago

:raised_hands: Thanks for opening your first issue here! Be sure to follow the issue template!

samdevaprasadvarde commented 2 years ago

Thanks! Appreciate any help here. Super cool action.

jaas666 commented 3 months ago

I have the same issue.. the package.json is not being updated on the project only on the runner. Did you ever figure this out? Or find another alternate action that does this?