in Windows, uploading to Amazon S3 and Rackspace Cloud Files fails

[diegolopez]

You have to change the save_to_storage from s3 and rackspace backends so instead of: (temp_path ? File.open(temp_path) : temp_data) you do: (temp_path ? File.open(temp_path, "rb") : temp_data)

Example for rackspace:

      def save_to_storage
        if save_attachment?
          @object = @@container.create_object(full_filename)
          @object.write((temp_path ? File.open(temp_path, "rb") : temp_data))
        end

        @old_filename = nil
        true
      end

[technoweenie]

Does it work with just File.open(temp_path, "rb")? #read will read it all into memory, which you do not want for large files. The S3Object#write method is designed to stream IO objects.

[diegolopez]

Yes!

So the example is: def save_to_storage if save_attachment? @object = @@container.create_object(full_filename)

FIXME: ugly hack to get it running on windows

      #somehow when You give file handle it won't read it
      if RUBY_PLATFORM =~ /(:?mswin|mingw)/
        @object.write((temp_path ? File.open(temp_path, "rb") : temp_data))
      else
        @object.write((temp_path ? File.open(temp_path) : temp_data))
      end
    end

    @old_filename = nil
    true
  end

Thanks!! I will edit the previous post.

[technoweenie]

Is this from the master branch? I haven't used this plugin in years. Also, you don't need the RUBY_PLATFORM check. You can pass 'rb' to it on unix systems. Other non-windows systems happily ignore the 'b'.

[diegolopez]

Does linux works ok with File.open(temp_path, "rb") ? So we don't need to do that ugly condition!

[technoweenie]

Correct.

[diegolopez]

I haven't commited my code...

[technoweenie]

You should do that...?

[diegolopez]

ok. thanks. I'll do it.

[technoweenie]

Ah yes, a pull request would be great if you want credit :)