Rajeshucsb master - Githubissues

technoweenie / guillotine

URL shortening hobby kit

http://techno-weenie.net/guillotine/

MIT License

486 stars 54 forks source link

Closed technoweenie closed 12 years ago

technoweenie commented 12 years ago

Combine #7 and #8. Should renumber this to 15 :)

travisbot commented 12 years ago

This pull request fails (merged 08d544a7 into a0639dd8).

technoweenie commented 12 years ago

I don't really like how the length/charset are passed in like this. I think we need to extract the some URL shortener classes:

The older md5 one
A length/charset one
One that encodes an autoincrement number into a string (seems to be a very common algorithm for shorteners).

This PR should be good for now though.

travisbot commented 12 years ago

This pull request passes (merged 8b28a222 into a0639dd8).