search

technoweenie / guillotine

URL shortening hobby kit
http://techno-weenie.net/guillotine/
MIT License
486 stars 54 forks source link

also allow ?foo=bar query params in the URL #8

Closed mrtazz closed 12 years ago

mrtazz commented 12 years ago

This has been a big annoyance while using guillotine for katana. A lot of URLs which I come across and want to share have query params in them. If there is no big reason why the query params are stripped, I would love to see this included.

travisbot commented 12 years ago

This pull request passes (merged c0d49b5c into a0639dd8).

technoweenie commented 12 years ago

I think I did that to keep people from duplicating links like:

foo.com
foo.com?a=1
foo.com?a=1#lol

I suppose we can stop stripping both ? and # though. Maybe make them configuration values so sites can enable/disable them according to their preferences.

mrtazz commented 12 years ago

Sounds like a good idea. I can take a stab at that, if it makes sense to include it in the pull request.

technoweenie commented 12 years ago

Don't worry about it, I got it. Thanks :)