search

technoweenie / restful-authentication

inactive project
MIT License
1.57k stars 280 forks source link

Support for .cat TLD domains #20

Closed franciscoj closed 10 years ago

franciscoj commented 14 years ago

Hi,

I've added support for .cat TLD domains on Authentication.domain_tld_regex. See http://www.domini.cat/en_index.html for more info.

Kind regards, Francisco.

jsanders commented 13 years ago

I know this is pretty old, but I'm wondering if anyone can comment on the logic behind listing out all supported tlds with more than 2 characters, rather than using something like "(?:[A-Z]{2,})" for the expression. Is there something horrible about that solution that I'm not seeing?

hakanai commented 11 years ago

I'm not convinced that anyone is looking at the issues on this project, but in case someone does end up here, I raised a very similar ticket on someone else's fork, only I didn't just fix it for .cat - https://github.com/jeremydurham/restful-authentication/pull/1

franciscoj commented 10 years ago

I don't think this will get integrated after 3 years, so I'm closing it :P

hakanai commented 10 years ago

Well, as long as someone makes the obvious alternative improvement of just not restricting the TLD at all, I wouldn't object. (Incidentally, I didn't find it for .cat, there was some other domain a customer was actually using.)