techoe / gflags

Automatically exported from code.google.com/p/gflags
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Set INTERFACE_COMPILE_DEFINITIONS of imported gflags library targets to define GFLAGS_DLL_DECL #78

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
CMake's 
[http://www.cmake.org/cmake/help/v2.8.12/cmake.html#prop_tgt:INTERFACE_COMPILE_D
EFINITIONS INTERFACE_COMPILE_DEFINITIONS] property on the imported targets can 
be used to specify the proper definition of GFLAGS_DLL_DECL if both shared and 
static libraries were build. In this case, both libraries require the inclusion 
of the same public header files, but with different GFLAGS_DLL_DECL in case of 
the VS compiler.

Original issue reported on code.google.com by andreas....@gmail.com on 25 Mar 2014 at 3:34

GoogleCodeExporter commented 9 years ago

Original comment by andreas....@gmail.com on 25 Mar 2014 at 3:38

GoogleCodeExporter commented 9 years ago
Postponing this change which requires a bit more thorough investigation of how 
this CMake setting is used, while the gflags 2.1.1 release which fixes the 
configuration of gflags_declare.h of gflags 2.1.0 were more urgent.

Original comment by andreas....@gmail.com on 30 Mar 2014 at 2:52