techouse / alfred-convert

Convert between different units with Alfred
MIT License
22 stars 4 forks source link

Minor Improvement Requests #2

Closed jwmann closed 1 year ago

jwmann commented 1 year ago

Love the workflow so far, I came from https://github.com/deanishe/alfred-convert which no longer works for me. I just have a couple requests, hopefully you find them useful enough to add them.

I love the home_currency environment variable but I feel like it would be useful putting it in the configuration section. It would get more visibility since you see the configuration immediately when you install the workflow.

I would also appreciate if there was a configuration for setting the default action to be the copy to clipboard instead of routing to the xe website. Perhaps the action could be a 'Toggle default action' or something similar so that when pressing command, it'll go to the website instead.

Lastly, I was just wondering what server the workflow is connecting to when performing a conversion. I'm unable to see what's inside the workflow binary so I'm not sure where it's connecting and what's it doing exactly. Just some transparency would be nice.

That's all, Thanks again!

jwmann commented 1 year ago

I just realized the the 'Copy to clipboard' feature doesn't copy the value to the clipboard. It copies the URL to xe.com. Is that what it's supposed to be? And if so, can you add that as a feature? I rarely care about xe.com, I just care about the value itself.

techouse commented 1 year ago

Hey,

nice to see some people actually use this 🙈 Was beginning to think this was dead. 😅

I love the home_currency environment variable but I feel like it would be useful putting it in the configuration section. It would get more visibility since you see the configuration immediately when you install the workflow.

Good idea 👍

I would also appreciate if there was a configuration for setting the default action to be the copy to clipboard instead of routing to the xe website. Perhaps the action could be a 'Toggle default action' or something similar so that when pressing command, it'll go to the website instead.

Perhaps, perhaps I could also use an additional modifier key to do that and keep the original action. 😇

Lastly, I was just wondering what server the workflow is connecting to when performing a conversion.

Explained in the README notes.

I'm unable to see what's inside the workflow binary so I'm not sure where it's connecting and what's it doing exactly. Just some transparency would be nice.

What do you mean? You literally stumbled upon the repo that holds the sourcecode 😂 This is the service that gets the rates from the ECB, specifically the eurofxref-daily.xml.

I just realized the the 'Copy to clipboard' feature doesn't copy the value to the clipboard. It copies the URL to xe.com. Is that what it's supposed to be?

Pretty much, as it holds a URL that's fed to the operating system. The idea of grabbing the value hasn't crossed my mind as the value is more or less indicative and not an actual spot/market value. That's why I decided to send people to Xe.com.

techouse commented 1 year ago

I would also appreciate if there was a configuration for setting the default action to be the copy to clipboard instead of routing to the xe website. Perhaps the action could be a 'Toggle default action' or something similar so that when pressing command, it'll go to the website instead.

Perhaps, perhaps I could also use an additional modifier key to do that and keep the original action. 😇

@jwmann Released now in v1.0.7. Check the README usage section for more info.

techouse commented 1 year ago

I love the home_currency environment variable but I feel like it would be useful putting it in the configuration section. It would get more visibility since you see the configuration immediately when you install the workflow.

Good idea 👍

@jwmann Released now in v1.1.0. Again, check the readme for more info.

jwmann commented 1 year ago

@techouse Thank you so much for adding those for me 🎉

Lastly, I was just wondering what server the workflow is connecting to when performing a conversion.

Explained in the README notes.

I'm unable to see what's inside the workflow binary so I'm not sure where it's connecting and what's it doing exactly. Just some transparency would be nice.

What do you mean? You literally stumbled upon the repo that holds the sourcecode 😂 This is the service that gets the rates from the ECB, specifically the eurofxref-daily.xml.

I feel silly, I didn't think you'd put the web server code in this repo as well. Most repos I see only show the alfred code parts that run locally. I appreciate the transparency! :)

I just realized the the 'Copy to clipboard' feature doesn't copy the value to the clipboard. It copies the URL to xe.com. Is that what it's supposed to be?

Pretty much, as it holds a URL that's fed to the operating system. The idea of grabbing the value hasn't crossed my mind as the value is more or less indicative and not an actual spot/market value. That's why I decided to send people to Xe.com.

Ah see, I hate to be a bother for something you're doing in your spare time but could you add that as a feature? I do a lot of conversions for estimating costs (roughly) and I will copy and paste the conversion exchange value into my calculations in excel. Putting the value directly in my clipboard on enter would skip a whole bunch of extra steps for me ❤️

techouse commented 1 year ago

I feel silly, I didn't think you'd put the web server code in this repo as well. Most repos I see only show the alfred code parts that run locally. I appreciate the transparency! :)

It's not webserver code. This is all client code.

Ah see, I hate to be a bother for something you're doing in your spare time but could you add that as a feature?

Done already in 1.0.7 :) Simply use cmd+enter, as the readme says.

jwmann commented 1 year ago

@techouse I should've tested it beforehand 😅 You're right, it works great thank you! :) 🎉