search

techouse / intl-date-time

International DateTime for Laravel Nova
MIT License
57 stars 21 forks source link

Update "illuminate/support" #13

Closed nibri10 closed 4 years ago

nibri10 commented 4 years ago

"illuminate/support": "^6.0" for compatible Laravel 6.0

techouse commented 4 years ago

I am not 100% sure. Laravel 6.0 is still super fresh out of the oven. Have you tested this yourself? I haven't had the time to play around with 6.0 myself for now. Besides, does Nova work with Laravel 6.0 yet?

nibri10 commented 4 years ago

I ran the test today and it doesn't work if it's less than 6.0 the Illuminati

nibri10 commented 4 years ago

yes it normally works both packages than it is necessary to upgrade to Illuminati 6.0 or higher

techouse commented 4 years ago

Hmm, how about you do something like "illuminate/support": "^5.6 || ^6.0", in order to keep it working with the 5.x branch?

nibri10 commented 4 years ago

yes it could do it this way but the newer versions are mostly backwards compatible. Laravel in version need version 6 without it the two repositories will not work

nibri10 commented 4 years ago

I tested both on version 5.8. * and work with Illuminati on version 6.0 smoothly

techouse commented 4 years ago

Ok. Merged.