search

techouse / intl-date-time

International DateTime for Laravel Nova
MIT License
57 stars 21 forks source link

Add a clear button when the field is not a required one #30

Closed danielztolnai closed 4 years ago

danielztolnai commented 4 years ago

When a field is not required, the user should be able to clear it. This is the same problem mentioned in #28. I implemented a quick solution using the already present ShortcutButtonsPlugin. The addition of the clear button is automatic based on the field's required flag.

techouse commented 4 years ago

Cool! I'll test this out later and merge it if all is OK.

techouse commented 4 years ago

So I just checked this and all the buttons now clear the date. So it's no good. You can fix it if you'd like but as it is I can not merge it.

danielztolnai commented 4 years ago

You're right, there was a typo in there. Now it is fixed.