ricklupton commented 2 years ago

I wanted to connect to mysqld via a UNIX socket rather than IP, so I added an option. Hope this looks ok.

techouse commented 2 years ago

Hi!

Thanks for the PR!!!

I've added some comments. Please resolve them.

Also, some tests using a socket would be nice :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #26 (9b253f2) into master (8558f1c) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   89.81%   89.85%   +0.04%     
==========================================
  Files           7        7              
  Lines         422      424       +2     
==========================================
+ Hits          379      381       +2     
  Misses         43       43

Impacted Files	Coverage Δ
mysql_to_sqlite3/cli.py	`95.55% <100.00%> (+0.10%)`	:arrow_up:
mysql_to_sqlite3/transporter.py	`98.37% <100.00%> (+<0.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8558f1c...9b253f2. Read the comment docs.

techouse commented 1 year ago

@ricklupton can you please resolve the comments above?

ricklupton commented 1 year ago

@techouse sorry for not responding to your comments!

I'm not working on this at the moment and don't have a local mysql database set up for testing at the moment. If it comes up again that I need this I'd be happy to try to add tests then but I'm afraid I don't have time at the moment.

If you want to complete this yourself and/or close it until/if I can look at it, please go ahead.

techouse commented 1 year ago

I'm closing this then. Feel free to reopen when you have time again.

techouse / mysql-to-sqlite3

Add option to connect to UNIX socket #26

Codecov Report