Corrected test get list accounts

techschool / simplebank

Backend master class: build a simple bank service in Go

MIT License

5.33k stars 961 forks source link

Corrected test get list accounts #124

Closed leedrum closed 3 months ago

leedrum commented 4 months ago

Issue: the expectation of the test case does not match with the test in video
How to fix: Add condition OR to the SQL query

techschool commented 4 months ago

This doesn't need to be corrected. The code evolved over time when new lectures are added. If you want to see the exact code as in the recorded video, you must look at the history: https://github.com/techschool/simplebank/commits/master/db/sqlc/account_test.go In the first commit, the code looks exactly as in the video.

leedrum commented 3 months ago

I do not agree with that test because we don't cover the pagination cases. btw, I think we can create another function to get a list account that doesn't depend on the owner. I will close this PR.