Add MyPy typing - Githubissues

techservicesillinois / phantom-toolbox

Splunk SOAR Application development libraries and utilities

Other

0 stars 0 forks source link

Add MyPy typing #1

Closed edthedev closed 1 year ago

edthedev commented 1 year ago

Context

Our update to our core template uses this repository. See https://github.com/techservicesillinois/splunk-soar-template/pull/31/files#diff-b877cc97fd2ea1db62dba0ab0c0b6797ca69e7d750920cb9cfe90f75697865e3

Note that mypy.ini excludes phantom-toolbox from MyPy rules. This is not our preference, and this issue is to resolve that.

Tasks

[x] add MyPy to lint steps in this repository
[x] add MyPy style type declarations in this repository as necessary to clear MyPy errors
remove MyPy phantom toolbox exclusion from techservicesillinois/splunk-soar-template - deferred to https://github.com/techservicesillinois/splunk-soar-template/issues/51

References

For MyPy linting see https://github.com/techservicesillinois/splunk-soar-template/blob/0c03cc0671140113bbd31275998fdbd405fb193e/Makefile#L95-L100 and related build step.