techtonik / python-patch

Library to parse and apply unified diffs
https://pypi.python.org/pypi/patch
112 stars 64 forks source link

Patch: move imports inside __main__ test #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Just as a minor cleanup issue, I also have a patch (attached) to move the 
imports which are only used when running as an application inside the __main__ 
test so they don't get imported if you're just using it as a library.

Not a major issue, but no reason to load them if they're not going to be used..

Original issue reported on code.google.com by foogod@gmail.com on 28 Aug 2010 at 2:23

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch. How would you prefer to appear in revision log, i.e. 

skip __main__ imports when used as a library. Fixes issue #11.

* Patch by: foogod <foogod@gmail.com>

Original comment by techtonik@gmail.com on 28 Aug 2010 at 8:46

GoogleCodeExporter commented 9 years ago
My primary email is "Alex Stewart <alex@foogod.com>", but really however you 
want to do it is fine by me (I don't really do this sort of thing for the 
credit :) )

Original comment by foogod@gmail.com on 29 Aug 2010 at 3:35

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r99.

Original comment by techtonik@gmail.com on 29 Aug 2010 at 6:10