search

techtonik / python-patch

Library to parse and apply unified diffs
https://pypi.python.org/pypi/patch
112 stars 65 forks source link

Google style guide....? #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi Anatoly:
I know that "inside" you still use the high density two spaces indentation, but 
I was wondering if the updated public style guide could make sense 
indentation-wise?
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation

I know this is a silly request... ignore and close asap if you feel so.

Original issue reported on code.google.com by pombreda...@gmail.com on 3 Mar 2014 at 8:17

GoogleCodeExporter commented 9 years ago 
I don't use tab key, so typing 4 spaces is more bothersome, but sometimes I 
indeed use 3 and 4 space indentation and for public projects 4 space is better 
for the reasons stated here 
http://legacy.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgobl
in-of-little-minds

But going now for 4 space reindent will make it harder to compare different 
versions of patch.py for people who maintain independent forks. I don't say it 
won't happen, but there should be a major rewrite to make it real.

So, yes, increasing readability is not a silly request, but I have to close it 
ASAP for now. I will consider this point in future.

Original comment by techtonik@gmail.com on 3 Mar 2014 at 8:55