search

techtonik / python-patch

Library to parse and apply unified diffs
https://pypi.python.org/pypi/patch
106 stars 63 forks source link

Configure wheels Fixes #43 #45

Closed graingert closed 7 years ago

techtonik commented 7 years ago

Well, thanks for taking action to add wheels support, but don't you think that this adds too much meaningless garbage and duplicate info to the project?

I created pypack in the first place to keep the code clean and maintenance minimal. So if you want to improve the state of art, I suggest to add wheel support to pypack. The process is described here - https://leanpub.com/reversingpythonpackaging along with ready to use code snippets.

But note the this will require creating tests on wheel packing, unpacking, to make the tool future proof against pip purists, who want to complicate the wheel installation process with (again) poorly argumented per file signature checks (which are easy to forge) etc.

graingert commented 7 years ago

don't you think that this adds too much meaningless garbage and duplicate info to the project?

I don't think that at all. None of this is duplicated

I created pypack

This PR obviates the need for this extra level of indirection ;)

graingert commented 7 years ago

Reasons why Python packaging suxx

Hmm ok...

graingert commented 7 years ago

And also you need to know, that I was expelled from Python community, because I didn't want to follow the lemmings way as I put it.

I consider myself a member of this community. Thanks for pointing this out. Maybe you should add this to your README.md?