search

techvalidate / pano

MIT License
0 stars 0 forks source link

Remove vendored redux #40

Closed jmckible closed 7 years ago

jmckible commented 7 years ago

As we embrace webpack for dependency management, we need to remove library loads from the pano js pipeline. Until CX is also migrated, you'll need to vendor a copy of redux and include it in your app/index.coffee.

Since this is a breaking change, my intention is to start a new v2.1.0 release of pano if this meets with your approval.

FYI @mmlindeboom Need 👍 from @mkmiller / @bullrico

jmckible commented 7 years ago

Do you foresee any i18n changes being breaking for Engage? The general road map I have in my mind is:

2.0.x - Bug fixes for the current UI 2.1.0 - Remove third party libraries from Pano. Engage will load them via webpack, CX via vendor/ 3.0.0 - Move all javascript from pano into another repo (pano-js is what I've been calling it). That repo would be packaged and loadable via webpack. The individual apps would need to load pano-js, until such time as rails/webpacker#348 is ready.

mkmiller commented 7 years ago

No, at this point anything I would need to modify would have appropriate fallbacks to English (for example I need to update the privacy policy link helper to be locale-aware)