search

techwizrd / MangaFox-Download-Script

A script that lets you download mangas from mangafox.com
77 stars 27 forks source link

Does not download improperly numbered ranges #1

Closed techwizrd closed 11 years ago

techwizrd commented 13 years ago

If you execute ~ $ python mfdl.py One_Piece 1 10 it doesn't download anything.

However, downloading a single chapter or the entire thing still works. I think it might have something to do with the chapter numbering, but I'm not sure. I'll have to investigate this further.

cympaul90 commented 13 years ago

this actually works on my end. I ran that exact command and it works just fine. same with a couple other mangas too.

techwizrd commented 13 years ago

The reason it doesn't work is that my script assumes the list of chapter numbers starts at 1 and has the chapter number increment by 1. A lot of mangas, like One Piece start with chapter numbers like Vol.00 Ch.001.1 so that the real chapter 1 is actually the thirds thing in the list of chapters.

I think that a possible solution would be to make the user enter the chapter numbers like 

~ $ python mfdl.py v01ch001 v02ch010
. A workaround would be wrapping it all a graphical interface so that the script can tell what chapter number actually corresponds to what place in the list of chapters, but that would bug some people. I'll probably go with the first solution.

Later on, I'll rework some of the image downloading portion to work better with progress bars and write an optional interface similar to how Ubuntu Software Center's downloading queue looks.

techwizrd commented 11 years ago

Fixed in commit fccb2e9b048f9959df580eab404082ef79011fac