search

techwizrd / MangaFox-Download-Script

A script that lets you download mangas from mangafox.com
77 stars 27 forks source link

ImportError when using BeautifulSoup4 #13

Closed DrVduck closed 11 years ago

DrVduck commented 12 years ago

I'm a noob, so there's your disclaimer.

Since beautiful soup updated to 4, the file needs a little tweak. Just import bs4 instead of beautifulsoup.

techwizrd commented 12 years ago

That will break the code on environments that do not have BeautifulSoup 4 installed. I'll be fixing that (as well as other issues) next week in a rewrite. Stay tuned. There are a lot of changes and fixes to be made and I'd like to pave the way for adding more features in the future.

On Tue, May 8, 2012 at 11:02 PM, DrVduck reply@reply.github.com wrote:

I'm a noob, so there's your disclaimer.

Since beautiful soup updated to 4, the file needs a little tweak. Just import bs4 instead of beautifulsoup.

Reply to this email directly or view it on GitHub: https://github.com/techwizrd/MangaFox-Download-Script/issues/13

DrVduck commented 12 years ago

Yeah... I'm learning a lot trying to get it working, so thank you for that.

On Tue, May 8, 2012 at 10:11 PM, Kunal Sarkhel < reply@reply.github.com

wrote:

That will break the code on environments that do not have BeautifulSoup 4 installed. I'll be fixing that (as well as other issues) next week in a rewrite. Stay tuned. There are a lot of changes and fixes to be made and I'd like to pave the way for adding more features in the future.

On Tue, May 8, 2012 at 11:02 PM, DrVduck reply@reply.github.com wrote:

I'm a noob, so there's your disclaimer.

Since beautiful soup updated to 4, the file needs a little tweak. Just import bs4 instead of beautifulsoup.

Reply to this email directly or view it on GitHub: https://github.com/techwizrd/MangaFox-Download-Script/issues/13

Reply to this email directly or view it on GitHub:

https://github.com/techwizrd/MangaFox-Download-Script/issues/13#issuecomment-5591858

"I finally stopped waiting for some one to save me. I started to save myself, and I found out there was all kinds of help waiting."

Chapak Patrick Smith

techwizrd commented 12 years ago

The quick fix would be:

try:
    import bs4 as BeautifulSoup
except ImportError:
    import BeautifulSoup

I'm considering moving away from BeautfulSoup though, so this will have to remain just a quick fix.

DrVduck commented 12 years ago

I did do this (well, I change the import to bs4... I didn't notice the structure of the try except bit).

The trouble I was having is it was going to the wrong URL. mangafox is now .me, instead of .com. And there's some oddness about the inclusion (or not) of the http:// at the beginning. I've exhausted my meager skills, I'll wait for the experts to get to it.

On Wed, May 9, 2012 at 5:46 AM, Kunal Sarkhel < reply@reply.github.com

wrote:

The quick fix would be:

try:
   import bs4 as BeautifulSoup
except ImportError:
   import BeautifulSoup

I'm considering moving away from BeautfulSoup though, so this will have to remain just a quick fix.

Reply to this email directly or view it on GitHub:

https://github.com/techwizrd/MangaFox-Download-Script/issues/13#issuecomment-5593243

"I finally stopped waiting for some one to save me. I started to save myself, and I found out there was all kinds of help waiting."

Chapak Patrick Smith

techwizrd commented 11 years ago

Fixed in commit eaa763854d4c8271eb3f3d2f55489a5d83c19fd5