search

techwizrd / MangaFox-Download-Script

A script that lets you download mangas from mangafox.com
77 stars 27 forks source link

Does not download properly #2

Closed cympaul90 closed 13 years ago

cympaul90 commented 13 years ago

The links that I get when it downloads are as follows:

Getting image url from /manga/urbane/v01/c001/1.html1.html Getting image url from /manga/urbane/v01/c001/1.html2.html Getting image url from /manga/urbane/v01/c001/1.html3.html Getting image url from /manga/urbane/v01/c001/1.html4.html Getting image url from /manga/urbane/v01/c001/1.html5.html Getting image url from /manga/urbane/v01/c001/1.html6.html and so on...

Is there a way to edit it so that it takes out the '1.html' before it starts going through the part of accessing all the links?

techwizrd commented 13 years ago

Thank you for alerting me of this issue. I think it has to do with how I'm formatting the arguments that form the image URL. Tomorrow, I will spend some time investigating why this is happening and how to reproduce this bug.

On Tue, Mar 29, 2011 at 8:34 PM, cympaul90 reply@reply.github.com wrote:

The links that I get when it downloads are as follows:

Getting image url from /manga/urbane/v01/c001/1.html1.html Getting image url from /manga/urbane/v01/c001/1.html2.html Getting image url from /manga/urbane/v01/c001/1.html3.html Getting image url from /manga/urbane/v01/c001/1.html4.html Getting image url from /manga/urbane/v01/c001/1.html5.html Getting image url from /manga/urbane/v01/c001/1.html6.html  and so on...

Is there a way to edit it so that it takes out the '1.html' before it starts going through the part of accessing all the links?

Reply to this email directly or view it on GitHub: https://github.com/techwizrd/MangaFox-Download-Script/issues/2

techwizrd commented 13 years ago

Ok, I've traced it down to the url fragments turning out like 

/manga/urbane/v01/c001/1.html
instead of 
/manga/urbane/v01/c001/
. I've got to dive into the html of the Mangafox and see what's up with the new html that's messing up my parsing.

techwizrd commented 13 years ago

I just fixed it by forcing the url_fragment to throw away the "1.html" by adding 

url_fragment = os.path.dirname(url_fragment) + "/"
in the get_chapter_image_urls function. The fix is located in commit f0c30da85ef8674b2682 if you're interested.

cympaul90 commented 13 years ago

thanks. Good job.