Closed SheaBelsky closed 5 years ago
Hi - sorry about closing this earlier, I thought this was one of those commits that people accidentally push here when they're developing for their local hackathon (we get "remove HackMIT" PRs a lot, haha). If you'd still like to contribute to resolving #79, can we split out just the relevant changes for that into a single PR? There are a lot of huge changes rolled into one here.
Sure; right now it is indeed the case that it's just pulling from what will become our site. I'll create a separate branch that doesn't have any of our stuff and create another PR with all of the agnostic/general stuff. The only thing I'll leave is the home page route, which might be important to other hackathons.
I'm going to close this since it seems like you've made a bunch of your own changes that aren't specific to the general Quill repository. We will remove the hardcoded references to HackMIT very soon, thanks for your help!
Resolves most of #79 . There are two places where these hardcoded instances cannot be removed:
index.html
root file, which doesn't inherit from any Angular controller to the best of my knowledgetext.hbs
email templates. Variables can be passed into these templates, but I don't even see where these templates are referenced. Would be easy to change.All references to a globally installed version of Gulp were changed to instead reference the locally installed version of Gulp. I also moved the Gulp dependencies to
devDependencies
(there was some duplication) and replaced a deprecated dependency (gulp-minify-css
=>gulp-clean-css
).The platform now runs on Webpack; Gulp and Babel have had both of their primary functions rolled into Webpack. Right now all the dependencies are installed and Webpack just copies them over as-is. Ideally, the dependencies would be imported where necessary in each file, and then Webpack will manage them.
Further, LESS is now the CSS engine, not SASS. The visual style used, Semantic-UI, is written in LESS, and it makes more sense to write CSS in that language in case there are specific things we need to override. In this case, I still need to manually import the icons to have them work on the frontend.