search

techy1999 / BlogFrontend

Nomads.solution is upcoming project for learner to learn new skill. Technical contribution to project. Writing blog and many other thing are under pipeline.S3 autodeployment link http://nomadsfrontendproduction.s3-website.ap-south-1.amazonaws.com/
https://www.nomads.solutions
MIT License
4 stars 6 forks source link

Refactore app.js file and routing system #114

Open Sky-De opened 3 months ago

Sky-De commented 3 months ago

Make this app more scalable with best practices

  1. replace the fragment that wraps the entire app with div along with the class app and role application
  2. replace #root style in global.css with .app class and move it to the app.css
  3. create routeConfig.js file and move all imports for a route to this file, create and export an array with route objects that contain path and element
  4. import routeConfig in app.js and map it to create all routes dynamically

After these modifications,the App will be more scalable and maintainable and follow best practices

Sky-De commented 3 months ago

@techy1999 hi there, assign this to me please

techy1999 commented 2 months ago
techy1999 commented 2 months ago

Hi @Sky-De ,Please check it. When i go to product detail page then it goes blog/6484743edcac0ceb2c3fefbc but it should go to /blogs/640ccae67a55cf500204fcab. Not found error is coming

Did you checked it. Please check it.

=== https://github.com/techy1999/BlogFrontend/pull/119 In this PR again why you have used the code of previous PR .I am not able to understand.

Lets have a call tomorrow and discuss these minor issues.

I will add you as project collaborator , let me know your availablity . Email me - nomads.contact.me@gmail.com

Sky-De commented 2 months ago

Hi @Sky-De ,Please check it. When i go to product detail page then it goes blog/6484743edcac0ceb2c3fefbc but it should go to /blogs/640ccae67a55cf500204fcab. Not found error is coming

Did you checked it. Please check it.

=== #119 In this PR again why you have used the code of previous PR .I am not able to understand.

Lets have a call tomorrow and discuss these minor issues.

I will add you as project collaborator , let me know your availablity . Email me - nomads.contact.me@gmail.com

@techy1999 I tried to check the issue, but I can not register to the app, it shows error NotFound, and blog route dose not show anything, I would like to have a conversation about all these, is it ok with you to connect on discord? let me know

techy1999 commented 1 month ago

Hi @Sky-De ,Please check it. When i go to product detail page then it goes blog/6484743edcac0ceb2c3fefbc but it should go to /blogs/640ccae67a55cf500204fcab. Not found error is coming Did you checked it. Please check it. === #119 In this PR again why you have used the code of previous PR .I am not able to understand. Lets have a call tomorrow and discuss these minor issues. I will add you as project collaborator , let me know your availablity . Email me - nomads.contact.me@gmail.com

@techy1999 I tried to check the issue, but I can not register to the app, it shows error NotFound, and blog route dose not show anything, I would like to have a conversation about all these, is it ok with you to connect on discord? let me know