search

techy2493 / ts-disc-control

A Discord Bot for syncing Discord roles to Teamspeak clients using Server Query.
GNU General Public License v3.0
5 stars 1 forks source link

/register command permission based #6

Open SSRPStevens opened 7 months ago

SSRPStevens commented 7 months ago

Currently, there is no way to stop an individual from using /register [Server Owner's TeamSpeak ID] granting themselves access to the Owner's role if they happen to sync.

My suggestion would be to check if the ID being registered has already been registered to another user at a minimum. Also, to allow a certain role ID to override that check to ensure someone doesn't steal an ID they shouldn't have.

If this is not possible, at least turn off /register when Discord oauth is enabled. Edited By Techy: Moved to separate issue

techy2493 commented 7 months ago

I'm going to split turn off /register into a separate issue.

techy2493 commented 7 months ago

We have a separate command for the override, /tsid, but it should be rounded out with additional features. I will make a separate issue for that as well.

techy2493 commented 7 months ago

Let's focus on, preventing users of the /register command from registering a tsid which is already used.

techy2493 commented 7 months ago

Also see #12 for more information regarding the desirability of a single user having more than on TSID, that may impact how this command is re-implemented

techy2493 commented 7 months ago

I believe this was actually addressed in V4, I will try to make time to test and will close this out in a day or two if so. It was inadvertent, so I may update this story to make the message the user receives when they do this more useful if it is ugly.