Output Buffer header number and size not overriding correctly

techyian / MMALSharp

C# wrapper to Broadcom's MMAL with an API to the Raspberry Pi camera.

MIT License

195 stars 33 forks source link

Output Buffer header number and size not overriding correctly #141

Closed techyian closed 4 years ago

techyian commented 4 years ago

Within the MMALPortConfig class there are properties to allow a user to override the number of buffers and their size but currently this does not work as expected. I believe this is due to connections being enabled prior to the port being started and this in turn appears to reset any custom value set. For reference, the code at fault is here and here - the connection enabling method should come after the port start.

techyian commented 4 years ago

Hmm on closer inspection this could also be due to not recommitting the buffer num/size changes in the port configuration methods. Will fix both as that seems to follow raspistill/vid behaviour more closely.