techyian / MMALSharp

C# wrapper to Broadcom's MMAL with an API to the Raspberry Pi camera.
MIT License
195 stars 33 forks source link

Remove OutputCallback from IConnectionCallbackHandler #179

Open MV10 opened 4 years ago

MV10 commented 4 years ago

As discussed recently, the OutputCallback in IConnectionCallbackHandler doesn't make sense. The buffer is not meant to contain data, it's a source of unused buffers. The else portion of the if-else block in MMALConnectionImpl's NativeConnectionCallback method invokes the callback, but the buffer Length is always zero, so it is never actually executed.