search

techyian / MMALSharp

C# wrapper to Broadcom's MMAL with an API to the Raspberry Pi camera.
MIT License
195 stars 33 forks source link

SetFlips and GetFlips only work on the still port #71

Closed nrandell closed 5 years ago

nrandell commented 5 years ago

In both SetFlips and GetFlips in MMALCameraExtensions.cs, they only operate on the StillPort

MMALCheck(MMALPort.mmal_port_parameter_set(camera.StillPort.Ptr, &mirror.Hdr), "Unable to set flips");

This has no impact on the video port. I guess we need another set of methods for SetVideoFlips and GetVideoFlips

techyian commented 5 years ago

Good spot! Thanks for raising this. I haven't had much time to focus on MMALSharp recently but I'm happy to accept a PR if you want to do this.