search

techyian / MMALSharp

C# wrapper to Broadcom's MMAL with an API to the Raspberry Pi camera.
MIT License
195 stars 33 forks source link

Fixed/custom name on taken pictures #90

Closed harniher closed 5 years ago

harniher commented 5 years ago

If you could have the ability to give the pictures a custom name will be great and useful, also if no name is given, the API saves the photo like the current version does (date/time format). Thank you

techyian commented 5 years ago

Thanks, will try and get this into the v0.5.1 release.

harniher commented 5 years ago

Thanks to you Ian, for your time and effort MMALSharp is a great API, and thanks for the fast response.

On Fri, Apr 5, 2019, 12:02 PM Ian Auty notifications@github.com wrote:

Thanks, will try and get this into the v0.5.1 release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/techyian/MMALSharp/issues/90#issuecomment-480388018, or mute the thread https://github.com/notifications/unsubscribe-auth/AvCV3N-iErKA0zQ8VCTI74r_k-_ujUm4ks5vd53NgaJpZM4cfiAh .

techyian commented 5 years ago

Hi @harniher, this work is now in the dev branch if you want to build from source. I have added an additional constructor to the FileStreamCaptureHandler class which takes a single string for the full file path. All subclasses of FileStreamCaptureHandler also implement this new constructor.

Let me know if you run into any issues with it. A new release will be done soon with this work in.

harniher commented 5 years ago

Hi @techyian , I've tested the code and it works like charm just one little bug that doesn´t affect the performance of the API, when it takes the photo the xterminal shows this

Preparing to take picture. Resolution: 0 x 0. Encoder: JPEG. Pixel Format: I420.

before the update it showed the actual resolution of the picture taken, the picture saved is of the defined resolution (640x480 in this case), just wanted to let you know this bug. Thanks for the prompt response/update

techyian commented 5 years ago

Thanks for letting me know :) I'll look into that, it'll have regressed from the work done for #88. Glad to hear it's working for you.

techyian commented 5 years ago

Just pushed a fix for this so should hopefully be ok now. It was getting the resolution from the Image Encoder which doesn't have a width/height stored and so was just outputting 0.